lordgamez commented on code in PR #2292:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2292#discussion_r4479007934
##########
minifi_main/MiNiFiMain.cpp:
##########
@@ -290,7 +291,24 @@ int main(int argc, char **argv) {
process_running.test_and_set();
std::atomic<bool> restart_token{false};
- const auto request_restart = [&] {
+ std::atomic<int32_t> exit_code{0};
+ std::mutex shutdown_request_mutex;
+ bool shutdown_requested = false;
Review Comment:
The mutex was used as multiple values had to be grouped under one lock, so I
had to check, but it seems to be viable with an atomic struct, I updated it in
https://github.com/apache/nifi-minifi-cpp/pull/2292/commits/6c3aea9cee887cb115528897f8304dad51a9a1b0
The placement of `flow_controller_running` was also changed to set it even
before any signal handler is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]