lordgamez commented on code in PR #2292:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2292#discussion_r4480692496
##########
minifi_main/MiNiFiMain.cpp:
##########
@@ -79,6 +81,41 @@ namespace utils = minifi::utils;
static std::atomic_flag flow_controller_running;
static std::atomic_flag process_running;
+enum class LifecycleState : int32_t {
+ RUNNING,
+ RESTART_REQUESTED,
+ SHUTDOWN_REQUESTED
+};
+
+struct LifecycleRequest {
+ LifecycleState state = LifecycleState::RUNNING;
+ int32_t exit_code = 0;
+};
+
+static_assert(std::atomic<LifecycleRequest>::is_always_lock_free);
+static std::atomic<LifecycleRequest> lifecycle_request;
+
+bool requestLifecycleChange(minifi::ShutdownType shutdown_type, int32_t
exit_code) {
+ auto current_request = lifecycle_request.load();
+ while (true) {
Review Comment:
compare_exchange_weak on line 110 updates current_request with the current
value of lifecycle_request when it fails, so the next iteration always works on
fresh data. Reloading inside the loop would only add a redundant load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]