bobpaulin commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4606502752
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/connector/StandardConnectorRepository.java:
##########
@@ -733,6 +938,74 @@ private void waitForState(final ConnectorNode connector,
final Set<ConnectorStat
}
}
+ private void waitForFlowEvolutionStatus(final ConnectorNode connector)
throws FlowUpdateException, IOException, InterruptedException {
Review Comment:
[Claude Opus 5.5] I don't think a separate limit is needed here:
Every node that actually drains is bounded by its own drain timeout. It then
reports FAILED, which wins the merge and ends this wait on every peer.
A peer that disconnects fails the wait right away, because the status
request requires every node to be connected.
The only way to wait forever was a peer that never began its attempt. That's
the silent START you found, which is now rejected during verification.
The apply phase's waitForState has no limit either, so I'd rather keep the
two waits consistent. I reworded the admin guide entry for
nifi.connector.flow.evolution.timeout. It no longer calls the wait unlimited,
and says the wait ends as soon as any node fails, times out, or disconnects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]