bobpaulin commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4606543549


##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java:
##########
@@ -976,6 +976,16 @@ default CompletableFuture<Void> stopComponents() {
      */
     void restoreFlowPreservingIdentifiers(VersionedExternalFlow 
proposedSnapshot);
 
+    /**
+     * Restores a previously persisted flow while controlling whether 
components resume their captured scheduled state.
+     * When {@code resumeComponentState} is false, the flow structure is 
restored so queued FlowFiles can reattach, but
+     * no component is started or enabled.
+     *
+     * @param proposedSnapshot the proposed flow whose Instance Identifiers 
should be used as runtime identifiers
+     * @param resumeComponentState whether components should resume the 
running or enabled state captured in the snapshot
+     */
+    void restoreFlowPreservingIdentifiers(VersionedExternalFlow 
proposedSnapshot, boolean resumeComponentState);

Review Comment:
   [Claude Opus 5.5] Agreed. There's now a single 
restoreFlowPreservingIdentifiers(VersionedExternalFlow, ResumeComponentState), 
and the overload is gone. The new ResumeComponentState enum has two values, 
RESUME_AS_PERSISTED and LEAVE_STOPPED. I made the same change to 
FrameworkFlowContext.restorePersistedFlow. RESUME_AS_PERSISTED still honors 
nifi.flowcontroller.autoResumeState, as the single-argument method did.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to