bobpaulin commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4606507037


##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/connector/StandardConnectorNode.java:
##########
@@ -979,7 +1032,7 @@ private void start(final FlowEngine scheduler, final 
CompletableFuture<Void> sta
                         
stateTransition.addPendingStartFuture(startCompleteFuture);
                         return;
                     }
-                    case STOPPED, PREPARING_FOR_UPDATE, UPDATED -> {
+                    case STOPPED, PREPARING_FOR_UPDATE, UPDATED, UPDATE_FAILED 
-> {

Review Comment:
   [Claude Opus 5.5] Agreed, the guard now lives in the node. start() refuses 
to run while an upgrade is pending, before it changes the desired state. So 
restartConnector, the asset synchronizer and any future caller can't run the 
new code on the pre-upgrade flow, and they get a message saying to start 
through the repository. Test: testStartRefusedWhileUpgradePending.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to