[
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905097#comment-15905097
]
Matt Gilman commented on NIFI-1961:
-----------------------------------
[~josephxsxn] Something should be done. Exactly what, I'm not sure. Many tests
have copies of nifi.properties from the time the test was added. As the
supported properties evolve, it becomes cumbersome to keep everything in sync.
There was work done a bit ago to inject NiFiProperties as needed and not access
it through a static getInstance() method. I'm not 100% but we may now be able
to update these tests to mock the necessary method(s) in NiFiProperties and get
rid of the copied test resources. That may be the best path forward if it's
feasible. To find the tests, search for 'nifi.properties' in any test resources.
However, there may be some tests where this isn't possible. I know there are
some integration tests in the web-api that stand up an instance of NiFi. Pretty
sure we'd need to keep the nifi.properties test resources in those cases.
Thanks!
> Test Resource - nifi.properties
> -------------------------------
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
> Issue Type: Task
> Components: Core Framework
> Reporter: Matt Gilman
> Assignee: Joseph Niemiec
> Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become
> increasingly stale with as the application has evolved. With the changes in
> 1.x we should at the very least update the copies or better yet, update the
> tests to mock out the necessary configuration to avoid the copies all
> together.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
