[
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905221#comment-15905221
]
Joseph Niemiec commented on NIFI-1961:
--------------------------------------
So I did alittle analysis just to get started -
There are 16 unique properties files, out of 35. Of these 16 unique (non-dupes)
files we have 4 that are only minor lib path changes, the other 12 have a
number of changes and will require me to compare deeper.
{code:bash}
diff
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
./nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/test/resources/conf/nifi.properties
30,31c30,32
< nifi.nar.library.directory=./target/resources/NiFiProperties/lib/
< nifi.nar.library.directory.alt=./target/resources/NiFiProperties/lib2/
---
> nifi.nar.library.directory=./target/test-classes/lib/
> nifi.nar.library.directory.alt=./target/test-classes/lib2/
>
{code}
It would seem to me the best way may be to reference the centralized
nifi.properties somehow as a resource? ie -
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
and then if they have different properties mock them to overwrite in the
tests?
Another idea was just to build a script that crawls, looks for differences from
the latest and prior nifi.properties nifi-commons config from the located one.
Then see if its properties where originally a default (prior or latest) or
different; if different leave the changed value but produce an output report?
And if its a prior default just update to the latest automatically?
This may be a bit more then trivial :)
> Test Resource - nifi.properties
> -------------------------------
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
> Issue Type: Task
> Components: Core Framework
> Reporter: Matt Gilman
> Assignee: Joseph Niemiec
> Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become
> increasingly stale with as the application has evolved. With the changes in
> 1.x we should at the very least update the copies or better yet, update the
> tests to mock out the necessary configuration to avoid the copies all
> together.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
