[ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905276#comment-15905276
 ] 

Matt Gilman commented on NIFI-1961:
-----------------------------------

To provide a little more background, because NiFiProperties was previously only 
accessible as a singleton through a static getInstance() methods, tests would 
need to supply their own copy of the file in order to inject a specific value. 
Now that this is no longer the case, I'm wondering if the tests can be updated 
to mock NiFiProperties and allow us to completely remove the nifi.properties in 
test resources. I'm not sure this is the case, but would probably be the most 
desirable outcome if possible.

> Test Resource - nifi.properties
> -------------------------------
>
>                 Key: NIFI-1961
>                 URL: https://issues.apache.org/jira/browse/NIFI-1961
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Core Framework
>            Reporter: Matt Gilman
>            Assignee: Joseph Niemiec
>            Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to