Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1941#discussion_r125163015
--- Diff:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPWorker.java
---
@@ -47,7 +46,7 @@
* @param snmp instance of {@link Snmp}
* @param target instance of {@link AbstractTarget}
*/
- public SNMPWorker(Snmp snmp, AbstractTarget target) {
+ protected SNMPWorker(Snmp snmp, AbstractTarget target) {
--- End diff --
I noticed a few public->private changes as well throughout the PR. While I
can't argue that the access modifier you went with would have been the best
initial choice, making a change back from public can break other people's code,
even if it isn't in NiFi now (in other words, the changes are a public API
change).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
