Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1941#discussion_r125164368
  
    --- Diff: 
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPGetter.java
 ---
    @@ -84,17 +83,21 @@ public ResponseEvent get() {
          * @return the list of {@link TreeEvent}
          */
         public List<TreeEvent> walk() {
    -        TreeUtils treeUtils = new TreeUtils(this.snmp, new 
DefaultPDUFactory());
    -        @SuppressWarnings("unchecked")
    -        List<TreeEvent> events = treeUtils.getSubtree(this.target, 
this.oid);
    -        return events;
    +        DefaultPDUFactory pduFactory = new DefaultPDUFactory();
    +
    +        // BEGIN WORKAROUND - For 
http://oosnmp.net/pipermail/snmp4j/2016-October/005749.html
    --- End diff --
    
    Great comment! For maintainability, do you think it would be helpful to put 
a comment in the pom to revisit this code if the snmp4j version is updated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to