[ 
https://issues.apache.org/jira/browse/NIFI-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085131#comment-16085131
 ] 

ASF GitHub Bot commented on NIFI-4181:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2003#discussion_r127116107
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVUtils.java
 ---
    @@ -37,6 +45,16 @@
             "The format used by Informix when issuing the UNLOAD TO file_name 
command with escaping disabled");
         static final AllowableValue MYSQL = new AllowableValue("mysql", "MySQL 
Format", "CSV data follows the format used by MySQL");
     
    +    static final AllowableValue SCHEMA_ACCESS_STRATEGY_EXPLICIT_COLUMNS = 
new AllowableValue("csv-explicit-columns", "Use '" + 
EXPLICIT_COLUMNS_DISPLAY_NAME + "' Property",
    +            "Takes the '" + EXPLICIT_COLUMNS_DISPLAY_NAME + "' property 
value as the explicit definition of the CSV columns.");
    +
    +    static final PropertyDescriptor EXPLICIT_COLUMNS = new 
PropertyDescriptor.Builder()
    +            .name(EXPLICIT_COLUMNS_DISPLAY_NAME)
    +            .description("Specifies the CSV columns expected as a comma 
separated list. Only used with the Schema Access Strategy '" + 
SCHEMA_ACCESS_STRATEGY_EXPLICIT_COLUMNS.getDisplayName() + "'.")
    +            .expressionLanguageSupported(false)
    --- End diff --
    
    Is there any reason why expression language should not be supported? Using 
a Variable Registry for example, the header list could be set externally.


> CSVReader and CSVRecordSetWriter services should be able to work given an 
> explicit list of columns.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4181
>                 URL: https://issues.apache.org/jira/browse/NIFI-4181
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Wesley L Lawrence
>            Priority: Minor
>         Attachments: NIFI-4181.patch
>
>
> Currently, to read or write a CSV file with *Record processors, the CSVReader 
> and CSVRecordSetWriters need to be given an avro schema. For CSV, a simple 
> column definition can also work.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to