[
https://issues.apache.org/jira/browse/NIFI-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085130#comment-16085130
]
ASF GitHub Bot commented on NIFI-4181:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2003#discussion_r127120939
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java
---
@@ -49,7 +51,7 @@
+ "the values. See Controller Service's Usage for further
documentation.")
public class CSVReader extends SchemaRegistryService implements
RecordReaderFactory {
- private final AllowableValue headerDerivedAllowableValue = new
AllowableValue("csv-header-derived", "Use String Fields From Header",
+ static final AllowableValue HEADER_DERIVED_ALLOWABLE_VALUE = new
AllowableValue("csv-header-derived", "Use String Fields From Header",
--- End diff --
Making this static (and capitalizing the name) aligns with the common
constant / property pattern, thanks! However it also looks like it can remain
private (at least that's what IntelliJ tells me ;)
> CSVReader and CSVRecordSetWriter services should be able to work given an
> explicit list of columns.
> ---------------------------------------------------------------------------------------------------
>
> Key: NIFI-4181
> URL: https://issues.apache.org/jira/browse/NIFI-4181
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Wesley L Lawrence
> Priority: Minor
> Attachments: NIFI-4181.patch
>
>
> Currently, to read or write a CSV file with *Record processors, the CSVReader
> and CSVRecordSetWriters need to be given an avro schema. For CSV, a simple
> column definition can also work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
