[ 
https://issues.apache.org/jira/browse/NIFI-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085956#comment-16085956
 ] 

ASF GitHub Bot commented on NIFI-4181:
--------------------------------------

Github user Wesley-Lawrence commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2003#discussion_r127265959
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVRecordSetWriter.java
 ---
    @@ -48,6 +54,7 @@
         @Override
         protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
             final List<PropertyDescriptor> properties = new 
ArrayList<>(super.getSupportedPropertyDescriptors());
    +        properties.add(CSVUtils.EXPLICIT_COLUMNS);
    --- End diff --
    
    Hmm. I'll take a stab at defining the new functionality in the 
`@capabilitydescription` in both `CSVReader` and `CSVRecordSetWriter`. 
    
    I think It's worth documenting, and explaining in `CSVReader` that columns 
can be renamed by using "Explicit Columns". As well as explaining in 
`CSVRecordSetWriter` that "Explicit Columns" doesn't rename columns, but does 
allow for re-ordering, while reminding users that the column names have been 
defined by whatever RecordReader is being used.


> CSVReader and CSVRecordSetWriter services should be able to work given an 
> explicit list of columns.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4181
>                 URL: https://issues.apache.org/jira/browse/NIFI-4181
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Wesley L Lawrence
>            Priority: Minor
>         Attachments: NIFI-4181.patch
>
>
> Currently, to read or write a CSV file with *Record processors, the CSVReader 
> and CSVRecordSetWriters need to be given an avro schema. For CSV, a simple 
> column definition can also work.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to