Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137881550
  
    --- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
    @@ -221,51 +223,28 @@ void 
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo() {
     
       if (!rest_user_name_.empty()) {
         std::string loginUrl = this->protocol_ + this->host_ + ":" + 
std::to_string(this->port_) + "/nifi-api/access/token";
    -    token = utils::get_token(loginUrl, this->rest_user_name_, 
this->rest_password_, this->securityConfig_);
    -    logger_->log_debug("Token from NiFi REST Api endpoint %s", token);
    +    utils::HTTPClient client(loginUrl, ssl_service);
    --- End diff --
    
    +1 for stripping raw curl and adding HTTPClient.


---

Reply via email to