Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137812730
--- Diff: libminifi/include/FlowController.h ---
@@ -124,14 +123,33 @@ class FlowController : public
core::controller::ControllerServiceProvider, publi
virtual bool isRunning() {
return running_.load();
}
+
// Whether the Flow Controller has already been initialized (loaded flow
XML)
virtual bool isInitialized() {
return initialized_.load();
}
// Start to run the Flow Controller which internally start the root
process group and all its children
- virtual bool start();
+ virtual int16_t start();
--- End diff --
For cases where we are overriding a member function already declared
virtual in the base class, the virtual keyword is redundant. For this case and
others like it, it would be better to use the override keyword so the compiler
will check that the function is indeed overridden as expected.
---
