Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137821983
  
    --- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
    @@ -23,13 +23,14 @@
     #include <mutex>
     #include <memory>
     #include <stack>
    -#include "utils/HTTPUtils.h"
    +#include "utils/HTTPClient.h"
    --- End diff --
    
    +1 on the rename to HTTPClient. To further improve the structural 
semantics, we may want to consider moving HTTPClient from utils/ and into io/, 
because it is a type of input/output.


---

Reply via email to