[ 
https://issues.apache.org/jira/browse/NIFI-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162533#comment-16162533
 ] 

ASF GitHub Bot commented on NIFI-3950:
--------------------------------------

Github user christophercurrie commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2140#discussion_r138257582
  
    --- Diff: nifi-assembly/pom.xml ---
    @@ -1,13 +1,13 @@
     <?xml version="1.0" encoding="UTF-8"?>
    -<!-- Licensed to the Apache Software Foundation (ASF) under one or more 
contributor 
    -    license agreements. See the NOTICE file distributed with this work for 
additional 
    -    information regarding copyright ownership. The ASF licenses this file 
to 
    -    You under the Apache License, Version 2.0 (the "License"); you may not 
use 
    -    this file except in compliance with the License. You may obtain a copy 
of 
    -    the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
    -    by applicable law or agreed to in writing, software distributed under 
the 
    -    License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
    -    OF ANY KIND, either express or implied. See the License for the 
specific 
    +<!-- Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
    --- End diff --
    
    Not deliberate, no, probably a result of my editor settings; I can revert 
them if they are unwanted.


> Separate AWS ControllerService API
> ----------------------------------
>
>                 Key: NIFI-3950
>                 URL: https://issues.apache.org/jira/browse/NIFI-3950
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: James Wing
>            Priority: Minor
>
> The nifi-aws-bundle currently contains the interface for the 
> AWSCredentialsProviderService as well as the service implementation, and 
> dependent abstract classes and processor classes.
> This results in the following warning logged as NiFi loads:
> {quote}
> org.apache.nifi.nar.ExtensionManager Component 
> org.apache.nifi.processors.aws.s3.PutS3Object is bundled with its referenced 
> Controller Service APIs 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderService.
>  The service APIs should not be bundled with component implementations that 
> reference it.
> {quote}
> Some [discussion of this issue and potential solutions occurred on the dev 
> list|http://apache-nifi.1125220.n5.nabble.com/Duplicated-processors-when-using-nifi-processors-dependency-td17038.html].
> We also need a migration plan in addition to the new structure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to