[
https://issues.apache.org/jira/browse/NIFI-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162539#comment-16162539
]
ASF GitHub Bot commented on NIFI-3950:
--------------------------------------
Github user christophercurrie commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2140#discussion_r138257973
--- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-nar/pom.xml ---
@@ -32,13 +32,14 @@
<dependencies>
<dependency>
<groupId>org.apache.nifi</groupId>
- <artifactId>nifi-standard-services-api-nar</artifactId>
+ <artifactId>nifi-aws-service-api-nar</artifactId>
+ <version>${project.version}</version>
<type>nar</type>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-aws-processors</artifactId>
- <version>1.4.0-SNAPSHOT</version>
--- End diff --
It's a style choice, one I follow out of habit. The release plugin is
perfectly happy with such references, and I find it clearer to declare the
version once at the the parent pom reference and stick with it, unless the
version is deliberately varying. But that's for your project to decide, so
happy to revert my habit here if wanted.
> Separate AWS ControllerService API
> ----------------------------------
>
> Key: NIFI-3950
> URL: https://issues.apache.org/jira/browse/NIFI-3950
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: James Wing
> Priority: Minor
>
> The nifi-aws-bundle currently contains the interface for the
> AWSCredentialsProviderService as well as the service implementation, and
> dependent abstract classes and processor classes.
> This results in the following warning logged as NiFi loads:
> {quote}
> org.apache.nifi.nar.ExtensionManager Component
> org.apache.nifi.processors.aws.s3.PutS3Object is bundled with its referenced
> Controller Service APIs
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderService.
> The service APIs should not be bundled with component implementations that
> reference it.
> {quote}
> Some [discussion of this issue and potential solutions occurred on the dev
> list|http://apache-nifi.1125220.n5.nabble.com/Duplicated-processors-when-using-nifi-processors-dependency-td17038.html].
> We also need a migration plan in addition to the new structure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
