[ 
https://issues.apache.org/jira/browse/NIFI-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165088#comment-16165088
 ] 

ASF GitHub Bot commented on NIFI-3950:
--------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2140#discussion_r138704486
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-nar/pom.xml ---
    @@ -32,13 +32,14 @@
         <dependencies>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
    -            <artifactId>nifi-standard-services-api-nar</artifactId>
    +            <artifactId>nifi-aws-service-api-nar</artifactId>
    +            <version>${project.version}</version>
                 <type>nar</type>
             </dependency>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
                 <artifactId>nifi-aws-processors</artifactId>
    -            <version>1.4.0-SNAPSHOT</version>
    --- End diff --
    
    We actually had a problem in the past with the release plugin and 
project.version, I can't remember the specifics and it may very well not be an 
issue anymore, but we did specifically make the choice to use the literal 
version everywhere so I'd prefer to stick with that


> Separate AWS ControllerService API
> ----------------------------------
>
>                 Key: NIFI-3950
>                 URL: https://issues.apache.org/jira/browse/NIFI-3950
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: James Wing
>            Priority: Minor
>
> The nifi-aws-bundle currently contains the interface for the 
> AWSCredentialsProviderService as well as the service implementation, and 
> dependent abstract classes and processor classes.
> This results in the following warning logged as NiFi loads:
> {quote}
> org.apache.nifi.nar.ExtensionManager Component 
> org.apache.nifi.processors.aws.s3.PutS3Object is bundled with its referenced 
> Controller Service APIs 
> org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderService.
>  The service APIs should not be bundled with component implementations that 
> reference it.
> {quote}
> Some [discussion of this issue and potential solutions occurred on the dev 
> list|http://apache-nifi.1125220.n5.nabble.com/Duplicated-processors-when-using-nifi-processors-dependency-td17038.html].
> We also need a migration plan in addition to the new structure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to