Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r139696520
  
    --- Diff: libminifi/include/FlowController.h ---
    @@ -158,7 +176,7 @@ class FlowController : public 
core::controller::ControllerServiceProvider, publi
       // first it will validate the payload with the current root node config 
for flowController
       // like FlowController id/name is the same and new version is greater 
than the current version
       // after that, it will apply the configuration
    -  bool applyConfiguration(std::string &configurePayload);
    +  bool applyConfiguration(const std::string &configurePayload);
    --- End diff --
    
    FlowConfiguratin should be sanitized of YAML related variable names. 
Unfortunately this was reintroduced in a recent PR. 


---

Reply via email to