Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137817535
--- Diff: libminifi/include/FlowController.h ---
@@ -158,7 +176,7 @@ class FlowController : public
core::controller::ControllerServiceProvider, publi
// first it will validate the payload with the current root node config
for flowController
// like FlowController id/name is the same and new version is greater
than the current version
// after that, it will apply the configuration
- bool applyConfiguration(std::string &configurePayload);
+ bool applyConfiguration(const std::string &configurePayload);
--- End diff --
I don't think 339 introduced this, but we are very tightly coupled with
YAML (and strings) here. FlowController should ideally be agnostic to
configuration formats and take in/apply some kind of abstract config structure.
---
