Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137885309
--- Diff: CMakeLists.txt ---
@@ -35,6 +35,8 @@ ENDIF(POLICY CMP0048)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=c++11 " COMPILER_SUPPORTS_CXX11)
CHECK_CXX_COMPILER_FLAG("-std=c++0x " COMPILER_SUPPORTS_CXX0X)
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ")
+SET(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
--- End diff --
Got it. If we add them back, and I understand correctly how this all is
working, then I think we should use distinct vars rather than exact copies of
the cmake parameters. Something like CXX_OPTIMIZATION_FLAGS. I do think
optimizations are going to be desirable. I almost feel like we need some kind
of automated/reproducible way to measure things before getting too fancy with
optimizations. I.e. a microbenchmark suite, something to measure bin size, and
something to measure memory usage.
---
