Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2160#discussion_r140266879
  
    --- Diff: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
 ---
    @@ -94,6 +95,27 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .build();
     
    +    protected static final PropertyDescriptor FLUSH_MODE = new 
PropertyDescriptor.Builder()
    +            .name("Flush Mode")
    +            .description("Set the new flush mode for a kudu session\n" +
    --- End diff --
    
    Would it be cleaner to define AllowableValue objects and set the 
description of each allowable value instead of doing it in the property 
description? (example in AbstractPutHBase). It's just a general question... I 
don't have a strong opinion on this.


---

Reply via email to