Github user cammachusa commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2160#discussion_r140314337
  
    --- Diff: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
 ---
    @@ -94,6 +95,27 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .build();
     
    +    protected static final PropertyDescriptor FLUSH_MODE = new 
PropertyDescriptor.Builder()
    +            .name("Flush Mode")
    +            .description("Set the new flush mode for a kudu session\n" +
    +                    "AUTO_FLUSH_SYNC: the call returns when the operation 
is persisted, else it throws an exception.\n" +
    +                    "AUTO_FLUSH_BACKGROUND: the call returns when the 
operation has been added to the buffer. This call should normally perform only 
fast in-memory" +
    +                    " operations but it may have to wait when the buffer 
is full and there's another buffer being flushed.\n" +
    +                    "MANUAL_FLUSH: the call returns when the operation has 
been added to the buffer, else it throws a KuduException if the buffer is 
full.")
    +            .allowableValues(SessionConfiguration.FlushMode.values())
    +            
.defaultValue(SessionConfiguration.FlushMode.AUTO_FLUSH_BACKGROUND.toString())
    +            .required(true)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    --- End diff --
    
    Agree!


---

Reply via email to