Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2160#discussion_r140355391
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -94,6 +95,27 @@
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ protected static final PropertyDescriptor FLUSH_MODE = new
PropertyDescriptor.Builder()
+ .name("Flush Mode")
+ .description("Set the new flush mode for a kudu session\n" +
--- End diff --
My only concern is: if we update the Kudu dependency and a new
SessionConfiguration.FlushMode option is made available in the library, the
contributor bumping the Kudu version will have to remember to update the
description otherwise there will be an undocumented option. But I'm fine with
this approach: it does not make a huge difference.
---
