[
https://issues.apache.org/jira/browse/MINIFICPP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235874#comment-16235874
]
ASF GitHub Bot commented on MINIFICPP-280:
------------------------------------------
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/168
@calebj thank you for the clean up contribution. Looks good to me; concur
with @phrocker's comments.
> Various refactoring and improvements
> ------------------------------------
>
> Key: MINIFICPP-280
> URL: https://issues.apache.org/jira/browse/MINIFICPP-280
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
> Priority: Minor
>
> * move extension tests into their respective folders
> * separate source and header files
> * remove unnecessary or nonexisting include directories
> * run linter on extension source files as part of linter target
> * clean up extensions according to linter
> * add ability to specify more than one include and source folder for linter
> * build catch main() and spdlib as shared objects for all tests (faster
> build!)
> * cmake doesn't know PRIVATE BEFORE, only BEFORE PRIVATE
> * borrow port changes to tests from MINIFICPP-60 for parallel testing
> * enable parallel testing in travis config
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
