[
https://issues.apache.org/jira/browse/MINIFICPP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234633#comment-16234633
]
ASF GitHub Bot commented on MINIFICPP-280:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168#discussion_r148364843
--- Diff: extensions/http-curl/tests/integration/C2NullConfiguration.cpp ---
@@ -29,26 +29,27 @@
#include <vector>
#include <iostream>
#include <sstream>
-#include "HTTPClient.h"
-#include "InvokeHTTP.h"
-#include "../TestBase.h"
+#include "client/HTTPClient.h"
+#include "processors/InvokeHTTP.h"
#include "utils/StringUtils.h"
#include "core/Core.h"
-#include "../include/core/logging/Logger.h"
--- End diff --
oh man. everytime I see these I get upset. Eclipse does this to me. I use
eclipse cdt and intellij for java....but never can understand why eclipse does
this on a fresh workspace.
> Various refactoring and improvements
> ------------------------------------
>
> Key: MINIFICPP-280
> URL: https://issues.apache.org/jira/browse/MINIFICPP-280
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
> Priority: Minor
>
> * move extension tests into their respective folders
> * separate source and header files
> * remove unnecessary or nonexisting include directories
> * run linter on extension source files as part of linter target
> * clean up extensions according to linter
> * add ability to specify more than one include and source folder for linter
> * build catch main() and spdlib as shared objects for all tests (faster
> build!)
> * cmake doesn't know PRIVATE BEFORE, only BEFORE PRIVATE
> * borrow port changes to tests from MINIFICPP-60 for parallel testing
> * enable parallel testing in travis config
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
