[
https://issues.apache.org/jira/browse/MINIFICPP-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249955#comment-16249955
]
ASF GitHub Bot commented on MINIFICPP-303:
------------------------------------------
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/185
MINIFICPP-303 Upgrade civetweb and rocksdb
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NiFiLocal/nifi-minifi-cpp MINIFICPP-303
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
----
> Upgrade civetweb and rocksdb
> ----------------------------
>
> Key: MINIFICPP-303
> URL: https://issues.apache.org/jira/browse/MINIFICPP-303
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
>
> These upgrades to the latest stable releases of civetweb
> ([v1.10|https://github.com/civetweb/civetweb/releases/tag/v1.10]) and RocksDB
> ([v5.8|https://github.com/facebook/rocksdb/releases/tag/v5.8]) bring numerous
> improvements. They might solve any issues similar to those in MINIFICPP-262.
> For civet, the most notable is OpenSSL v1.1 support. It was partially
> backported to the version in the minifi tree (1.9.1), but still had issues
> matching some OpenSSL v1.1 interface changes. Civetweb release v1.10 has
> complete and official support.
> RocksDB v5.8 comes with the following bugfixes:
> * Fix wrong latencies in rocksdb.db.get.micros, rocksdb.db.write.micros, and
> rocksdb.sst.read.micros.
> * Fix incorrect dropping of deletions during intra-L0 compaction.
> * Fix transient reappearance of keys covered by range deletions when memtable
> prefix bloom filter is enabled.
> * Fix potentially wrong file smallest key when range deletions separated by
> snapshot are written together.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
