[
https://issues.apache.org/jira/browse/MINIFICPP-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252124#comment-16252124
]
ASF GitHub Bot commented on MINIFICPP-303:
------------------------------------------
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
I can build & make test this on CentOS 7.4 with devtoolset-6 (GCC 6.3.1),
but it fails when using devtoolset-7 (GCC 7.1.1).
```
In file included from
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/write_batch_internal.h:12:0,
from
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/column_family.h:20,
from
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/version_set.h:31,
from
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/compaction.h:11,
from
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/compaction_iterator.h:12,
from
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/builder.cc:16:
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/write_thread.h:
In member function ‘std::mutex& rocksdb::WriteThread::Writer::StateMutex()’:
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/write_thread.h:225:78:
error: dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
return
*static_cast<std::mutex*>(static_cast<void*>(&state_mutex_bytes));
```
I would still merge this because I wasn't able to build with devtoolset-7
before this change, either. It's an improvement to have the newer versions, and
I can't find any regressions.
> Upgrade civetweb and rocksdb
> ----------------------------
>
> Key: MINIFICPP-303
> URL: https://issues.apache.org/jira/browse/MINIFICPP-303
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Caleb Johnson
>
> These upgrades to the latest stable releases of civetweb
> ([v1.10|https://github.com/civetweb/civetweb/releases/tag/v1.10]) and RocksDB
> ([v5.8|https://github.com/facebook/rocksdb/releases/tag/v5.8]) bring numerous
> improvements. They might solve any issues similar to those in MINIFICPP-262.
> For civet, the most notable is OpenSSL v1.1 support. It was partially
> backported to the version in the minifi tree (1.9.1), but still had issues
> matching some OpenSSL v1.1 interface changes. Civetweb release v1.10 has
> complete and official support.
> RocksDB v5.8 comes with the following bugfixes:
> * Fix wrong latencies in rocksdb.db.get.micros, rocksdb.db.write.micros, and
> rocksdb.sst.read.micros.
> * Fix incorrect dropping of deletions during intra-L0 compaction.
> * Fix transient reappearance of keys covered by range deletions when memtable
> prefix bloom filter is enabled.
> * Fix potentially wrong file smallest key when range deletions separated by
> snapshot are written together.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
