Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2287#discussion_r152586939
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java
 ---
    @@ -129,6 +130,12 @@
                 .defaultValue("100")
                 .expressionLanguageSupported(true)
                 .build();
    +    
    +    public static final PropertyDescriptor VERSION_ATTRIBUTE = new 
PropertyDescriptor.Builder()
    +                   .name("Version").displayName("Version Attribute")
    +                   .description("The name of the attribute containing the 
version for each FlowFile. Only used for index operation. Forces External 
Versioning")
    +                   
.required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
    --- End diff --
    
    If this property is not required, does it need to refer to an attribute? If 
instead you support expression language and set the validator to 
NON_EMPTY_VALIDATOR, then you can still set the Version to the value of an 
attribute by using expression language, or you can hardcode it without needing 
an incoming attribute, in the case where it will/should always be the same


---

Reply via email to