Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2287#discussion_r152590804
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java
 ---
    @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
                     final String index = 
context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue();
                     final String docType = 
context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue();
                     final String indexOp = 
context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue();
    +                final Long version = version_attribute != null ? 
Long.parseLong(file.getAttribute(version_attribute)) : null;
    --- End diff --
    
    FYI you could also call `file.getAttribute(version_attribute).asLong()`. 
Also if the field is supposed to contain a Long value (if set), then you should 
consider using a LONG_VALIDATOR for that field (rather than the 
NON_EMPTY_VALIDATOR I suggested in my other comment). This will avoid a 
possible NumberFormatException if someone enters invalid input.


---

Reply via email to