Github user otherview commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2287#discussion_r152829112
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java
---
@@ -129,6 +130,12 @@
.defaultValue("100")
.expressionLanguageSupported(true)
.build();
+
+ public static final PropertyDescriptor VERSION_ATTRIBUTE = new
PropertyDescriptor.Builder()
+ .name("Version").displayName("Version Attribute")
+ .description("The name of the attribute containing the
version for each FlowFile. Only used for index operation. Forces External
Versioning")
+
.required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
--- End diff --
Idea here was to follow the same logic as the ID_ATTRIBUTE so not to break
pattern. But not having the field required, so you can Update/Upsert documents.
Actually I think the Id should be expression enabled and even allowed to be
null - You can index docs without an ID.
What change would you sugest ?
---
