[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329574#comment-16329574
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194578
  
    --- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
    @@ -519,7 +519,7 @@ bool RawSiteToSiteClient::bootstrap() {
       tearDown();
     
       if (establish() && handShake() && negotiateCodec()) {
    -    logger_->log_info("Site2Site Ready For data transaction");
    +    logger_->log_trace("Site2Site Ready For data transaction");
    --- End diff --
    
    If you were to set the log level to debug one might expect there to be 
something here, as you would need to select trace and inevitably trace the 
entire flow of execution vice getting debug information. 


> Refine log levels and messages
> ------------------------------
>
>                 Key: MINIFICPP-365
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-365
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>            Priority: Major
>             Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to