[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329590#comment-16329590
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196401
  
    --- Diff: libminifi/src/capi/Plan.cpp ---
    @@ -115,7 +115,7 @@ bool linkToPrevious) {
     
     bool ExecutionPlan::setProperty(const std::shared_ptr<core::Processor> 
proc, const std::string &prop, const std::string &value) {
       uint32_t i = 0;
    -  logger_->log_info("Attempting to set property %s %s for %s", prop, 
value, proc->getName());
    +  logger_->log_debug("Attempting to set property %s %s for %s", prop, 
value, proc->getName());
    --- End diff --
    
    oh man this is definitely me! I copied and pasted a lot of these. Thanks 
for catching this!


> Refine log levels and messages
> ------------------------------
>
>                 Key: MINIFICPP-365
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-365
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>            Priority: Major
>             Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to