[ 
https://issues.apache.org/jira/browse/MINIFICPP-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329598#comment-16329598
 ] 

ASF GitHub Bot commented on MINIFICPP-365:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196896
  
    --- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
    @@ -193,17 +193,17 @@ void RemoteProcessorGroupPort::onTrigger(const 
std::shared_ptr<core::ProcessCont
     
       std::unique_ptr<sitetosite::SiteToSiteClient> protocol_ = nullptr;
       try {
    -    logger_->log_info("get protocol in on trigger");
    +    logger_->log_trace("get protocol in on trigger");
         protocol_ = getNextProtocol();
     
         if (!protocol_) {
    -      logger_->log_info("no protocol, yielding");
    --- End diff --
    
    This one should likely be debug otherwise we'd need to get to trace to 
support this. The one above is definitely a trace. 


> Refine log levels and messages
> ------------------------------
>
>                 Key: MINIFICPP-365
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-365
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>            Priority: Major
>             Fix For: 0.4.0
>
>
> minifi-app.log is verbose and includes a lot of information at an INFO level 
> that is below the typical information a person might care to see.  Some 
> statements are likely extraneous and remnants of development, some should be 
> dropped to a lower priority and others seem duplicative.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to