Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/118#discussion_r175506629
--- Diff:
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentInfo.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.minifi.c2.model;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+
+import java.util.Collection;
+
+@ApiModel
+public class AgentInfo {
+
+ private String identifier;
+ // TODO, do we also need identity. e.g., cert DN
+ private String agentClass;
+ private Collection<String> tags;
--- End diff --
I was thinking it would be nice for an operator to be able to tag agents
with arbitrary labels that they can then use as filters in future queries. I'm
not sure those tags would be just on the C2 server in the agents it is
tracking, or if they could also be set on agents when they are provisioned and
deployed, similar to the agent class labels.
Thanks for calling this out. Now that I think about it, I'd like to drop
this field for now so that we can properly discuss (on the mailing list, JIRA,
etc) if this is valuable and if so how to implement it.
---
