Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/118#discussion_r175517256
--- Diff:
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentRepositoryStatus.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.minifi.c2.model;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+
+@ApiModel
+public class AgentRepositoryStatus {
+
+ private Long size;
+ private Long sizeMax;
+ private Long count;
+ private Long countMax;
--- End diff --
I'm not tied to the names of these fields. I agree that storageMax is
better than sizeMax and that 'size' in general is ambiguous without reading the
description. Better to avoid confusion.
I want to make this change so that the names stay consistent with the
FlowQueueStatus fields if possible. My understanding (correct me if this is
wrong) is that both queues and repositories have two important metrics:
1. number of items they currently contain
2. the data/storage footprint of those items
And that both of these metrics can number configurable caps (i.e., the "max
value") for both queues and repositories.
If that understanding is not correct, let me know as I'll need to correct
these model classes. If it is correct, what would be the best names to use that
would be consistent with how these values are labeled in MiNiFi's configuration?
---
