Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/118#discussion_r175509585
--- Diff:
minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentInfo.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.minifi.c2.model;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+
+import java.util.Collection;
+
+@ApiModel
+public class AgentInfo {
+
+ private String identifier;
+ // TODO, do we also need identity. e.g., cert DN
+ private String agentClass;
--- End diff --
_[Some background to those who are new to the terminology that's starting
to formulate around these features: In this context, class != OO type. Rather,
it's intended as a category/purpose label for a MiNiFi agent that could be used
for a variety of purposes from a C2 server: e.g., seeing summary views of a
class, showing all agents of a particular class, scheduling a bulk operation
(such as deploying flow update) to all agents that match a particular class.]_
In the data model, I do have an AgentClass type that could be used here,
but I think that will really just be metadata that one can associate with a
class in the C2 server. We'll have to enforce agent class name uniqueness, so
that in contexts where the full agent class metadata is not needed, just the
class name can be used.
---
