[ 
https://issues.apache.org/jira/browse/NIFI-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505939#comment-16505939
 ] 

ASF GitHub Bot commented on NIFI-5221:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2751#discussion_r194034751
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
 ---
    @@ -205,11 +210,21 @@
                 .defaultValue(NO_SERVER_SIDE_ENCRYPTION)
                 .build();
     
    +    public static final PropertyDescriptor OBJECT_TAGS = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Yep, wouldn't it be more flexible?
    With the current approach, it assumes that you always have the same set of 
tags (even if the values can change based on ffs attributes, the keys would 
always be the same). With the regular expression, you could easily manage the 
case where you have one ff with attributes tagS3_country=FR, 
tagS3_security=topsecret and one flow file with only tagS3_country=US. You 
would set the tag regular expression to tagS3.* and you would have the tags 
created using the attributes matching the regex. Does it make sense or am I 
missing something?


> Add Object Tagging support for AWS S3 Processors
> ------------------------------------------------
>
>                 Key: NIFI-5221
>                 URL: https://issues.apache.org/jira/browse/NIFI-5221
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Sivaprasanna Sethuraman
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Major
>
> AWS has introduced new set of functionalities that enable the S3 bucket and 
> objects to be tagged. This can be useful for data classification purposes and 
> with new regulatory process related to data are being introduced such as 
> GDPR, object tagging can be quite useful and helpful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to