[ 
https://issues.apache.org/jira/browse/NIFI-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509680#comment-16509680
 ] 

ASF GitHub Bot commented on NIFI-5221:
--------------------------------------

Github user zenfenan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2751#discussion_r194756360
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
 ---
    @@ -205,11 +210,21 @@
                 .defaultValue(NO_SERVER_SIDE_ENCRYPTION)
                 .build();
     
    +    public static final PropertyDescriptor OBJECT_TAGS = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    The keys not necessarily be the same, right? It can change since the 
property supports expression language so the key-values can be dynamically 
generated and substituted using expression language. 
    
    Having said that, I do understand your point. My only thought is that when 
the developer is assigning tags to the FlowFiles, he/she would be using either 
`UpdateAttribute` or more preferably `ExecuteScript` to do some basic 
processing and assign tags according to some conditions. Correct? In that case, 
I honestly don't see the regular expression approach adding more value than the 
JSON approach. They seem more or less the same. I mean, if the developer is 
using `ExecuteScript` to generate the tags and add it to FlowFile attributes, 
he/she might as well generate the entire JSON and assign it to a FlowFile 
attribute and that FlowFile attribute can be given as the property value here 
and the substitution can be done. Makes sense?


> Add Object Tagging support for AWS S3 Processors
> ------------------------------------------------
>
>                 Key: NIFI-5221
>                 URL: https://issues.apache.org/jira/browse/NIFI-5221
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Sivaprasanna Sethuraman
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Major
>
> AWS has introduced new set of functionalities that enable the S3 bucket and 
> objects to be tagged. This can be useful for data classification purposes and 
> with new regulatory process related to data are being introduced such as 
> GDPR, object tagging can be quite useful and helpful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to