[ 
https://issues.apache.org/jira/browse/NIFI-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509668#comment-16509668
 ] 

ASF GitHub Bot commented on NIFI-5221:
--------------------------------------

Github user zenfenan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2751#discussion_r194751872
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
 ---
    @@ -307,6 +328,20 @@ private boolean commit(final ProcessContext context, 
final ProcessSession sessio
             return willCommit;
         }
     
    +    private Map<String, String> writeObjectTags(AmazonS3 client, 
S3VersionSummary versionSummary) {
    +        final GetObjectTaggingResult taggingResult = 
client.getObjectTagging(new 
GetObjectTaggingRequest(versionSummary.getBucketName(), 
versionSummary.getKey()));
    --- End diff --
    
    I agree. I'll change the default value to `false`.


> Add Object Tagging support for AWS S3 Processors
> ------------------------------------------------
>
>                 Key: NIFI-5221
>                 URL: https://issues.apache.org/jira/browse/NIFI-5221
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Sivaprasanna Sethuraman
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Major
>
> AWS has introduced new set of functionalities that enable the S3 bucket and 
> objects to be tagged. This can be useful for data classification purposes and 
> with new regulatory process related to data are being introduced such as 
> GDPR, object tagging can be quite useful and helpful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to