[
https://issues.apache.org/jira/browse/NIFI-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534774#comment-16534774
]
ASF GitHub Bot commented on NIFI-5377:
--------------------------------------
GitHub user markobean opened a pull request:
https://github.com/apache/nifi/pull/2847
NIFI-5377 prevent infinite loop if a controller service circular refe…
…rence exists
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markobean/nifi NIFI-5377
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2847
----
commit dc43aa9d956826a777ae2a0a647356ed7f28a9ba
Author: Mark Bean <mark.o.bean@...>
Date: 2018-07-06T12:29:00Z
NIFI-5377 prevent infinite loop if a controller service circular reference
exists
----
> StandardNiFiServiceFacade: Recursive method call allows for infinite loop
> when a circular reference exists
> ----------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5377
> URL: https://issues.apache.org/jira/browse/NIFI-5377
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.7.0
> Reporter: Jon Kessler
> Assignee: Mark Bean
> Priority: Minor
>
> At a minimum, when you attempt to view a list of controller services in the
> gui this specific method is called to obtain a set of referenced controller
> service identifiers. If there is a circular dependency in that set, you end
> up with an infinite loop that ultimately results the user being redirected to
> an error page in the gui.
> The method in question is
> findControllerServiceReferencingComponentIdentifiers. It checks to see if
> each node has been visited already but does not add them to the set until
> after recursively calling itself again. If the line "visited.add(node);" is
> moved above the method call, this will be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
