[ 
https://issues.apache.org/jira/browse/NIFI-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535018#comment-16535018
 ] 

Mark Bean commented on NIFI-5377:
---------------------------------

FYI- NIFI-5368 is related (but not covered under this ticket). I'm modifying 
StandardProcessorTestRunner to validate a controller service before enabling 
it. The Mock framework is not handing this correctly currently. Unfortunately, 
this broke unit tests which were taking advantage of this loophole (knowingly 
or otherwise)

> StandardNiFiServiceFacade: Recursive method call allows for infinite loop 
> when a circular reference exists
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-5377
>                 URL: https://issues.apache.org/jira/browse/NIFI-5377
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.7.0
>            Reporter: Jon Kessler
>            Assignee: Mark Bean
>            Priority: Minor
>
> At a minimum, when you attempt to view a list of controller services in the 
> gui this specific method is called to obtain a set of referenced controller 
> service identifiers. If there is a circular dependency in that set, you end 
> up with an infinite loop that ultimately results the user being redirected to 
> an error page in the gui.
> The method in question is 
> findControllerServiceReferencingComponentIdentifiers. It checks to see if 
> each node has been visited already but does not add them to the set until 
> after recursively calling itself again. If the line "visited.add(node);" is 
> moved above the method call, this will be resolved.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to