[
https://issues.apache.org/jira/browse/NIFI-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535009#comment-16535009
]
ASF GitHub Bot commented on NIFI-5377:
--------------------------------------
Github user JonathanKessler commented on the issue:
https://github.com/apache/nifi/pull/2847
@mcgilman Did you experience this behavior on the graph or in a unit test?
After fixing the infinite loop locally I was never able to enable the
controller services on the graph because they were never valid: A depends on B
which depends on A. A is not enabled so B cannot be enabled and vice versa.
> StandardNiFiServiceFacade: Recursive method call allows for infinite loop
> when a circular reference exists
> ----------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5377
> URL: https://issues.apache.org/jira/browse/NIFI-5377
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.7.0
> Reporter: Jon Kessler
> Assignee: Mark Bean
> Priority: Minor
>
> At a minimum, when you attempt to view a list of controller services in the
> gui this specific method is called to obtain a set of referenced controller
> service identifiers. If there is a circular dependency in that set, you end
> up with an infinite loop that ultimately results the user being redirected to
> an error page in the gui.
> The method in question is
> findControllerServiceReferencingComponentIdentifiers. It checks to see if
> each node has been visited already but does not add them to the set until
> after recursively calling itself again. If the line "visited.add(node);" is
> moved above the method call, this will be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
