[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559770#comment-16559770
]
ASF GitHub Bot commented on NIFI-5468:
--------------------------------------
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2921
NIFI-5468 Add toolkit to NiFi docker image and use zip archive
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pepov/nifi NIFI-5468
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2921.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2921
----
commit 00ab8845e55eb5dba30347bf4a0aa9fdacc0332a
Author: pepov <peterwilcsinszky@...>
Date: 2018-07-27T12:53:39Z
NIFI-5468 Add toolkit to NiFi docker image and use zip archive
commit 48b3046400ee096854d3e7552acee9262d337e61
Author: pepov <peterwilcsinszky@...>
Date: 2018-07-27T13:37:04Z
NIFI-5468 nifi toolkit configuration
----
> Add toolkit to NiFi docker image and use zip archive
> ----------------------------------------------------
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
> Affects Versions: 1.8.0
> Reporter: Peter Wilcsinszky
> Assignee: Peter Wilcsinszky
> Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
