[ 
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562169#comment-16562169
 ] 

ASF GitHub Bot commented on NIFI-5468:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2921#discussion_r206252629
  
    --- Diff: nifi-docker/dockermaven/sh/secure.sh ---
    @@ -45,13 +45,23 @@ prop_replace 'nifi.security.truststore'         
"${TRUSTSTORE_PATH}"
     prop_replace 'nifi.security.truststoreType'     "${TRUSTSTORE_TYPE}"
     prop_replace 'nifi.security.truststorePasswd'   "${TRUSTSTORE_PASSWORD}"
     
    +prop_replace 'keystore'           "${KEYSTORE_PATH}"        
${nifi_toolkit_props_file}
    +prop_replace 'keystoreType'       "${KEYSTORE_TYPE}"        
${nifi_toolkit_props_file}
    +prop_replace 'keystorePasswd'     "${KEYSTORE_PASSWORD}"    
${nifi_toolkit_props_file}
    --- End diff --
    
    Same comment about `keyPasswd`. 


> Add toolkit to NiFi docker image and use zip archive
> ----------------------------------------------------
>
>                 Key: NIFI-5468
>                 URL: https://issues.apache.org/jira/browse/NIFI-5468
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Docker
>    Affects Versions: 1.8.0
>            Reporter: Peter Wilcsinszky
>            Assignee: Peter Wilcsinszky
>            Priority: Major
>             Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to 
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the 
> zip release and avoid generating the tar.gz anymore. For the discussion seeĀ 
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to