[
https://issues.apache.org/jira/browse/NIFI-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561830#comment-16561830
]
ASF GitHub Bot commented on NIFI-5468:
--------------------------------------
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206105937
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -23,11 +23,15 @@ LABEL site="https://nifi.apache.org";
ARG UID=1000
ARG GID=1000
ARG NIFI_VERSION=1.8.0
-ARG MIRROR=https://archive.apache.org/dist
+ARG MIRROR_BASE_URL=https://archive.apache.org/dist
+ARG ARCHIVE_BASE_URL=https://archive.apache.org/dist
+
+ENV NIFI_BASE_DIR=/opt/nifi
+ENV NIFI_HOME=${NIFI_BASE_DIR}/nifi-${NIFI_VERSION}
+
+ENV
NIFI_BINARY_PATH=${NIFI_BINARY_PATH:-/nifi/${NIFI_VERSION}/nifi-${NIFI_VERSION}-bin.zip}
--- End diff --
Did you forget to add `/opt` here to this? `PATH:-/nifi/${NIFI_VERSION}`?
From the diff, it doesn't look like `/nifi` would be a valid starting path.
> Add toolkit to NiFi docker image and use zip archive
> ----------------------------------------------------
>
> Key: NIFI-5468
> URL: https://issues.apache.org/jira/browse/NIFI-5468
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
> Affects Versions: 1.8.0
> Reporter: Peter Wilcsinszky
> Assignee: Peter Wilcsinszky
> Priority: Major
> Fix For: 1.8.0
>
>
> NiFi toolkit is an essential tool for a NiFi installation and makes sense to
> include it by default in the NiFi Docker image.
> Using the zip archive is a step to make possible switching completely to the
> zip release and avoid generating the tar.gz anymore. For the discussion see
> http://apache-nifi-developer-list.39713.n7.nabble.com/DISCUSS-Tar-Gzip-vs-Zip-td19175.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
