Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r207919579
  
    --- Diff: extensions/pcap/CapturePacket.cpp ---
    @@ -54,13 +54,15 @@ namespace processors {
     std::shared_ptr<utils::IdGenerator> CapturePacket::id_generator_ = 
utils::IdGenerator::getIdGenerator();
     core::Property CapturePacket::BaseDir("Base Directory", "Scratch directory 
for PCAP files", "/tmp/");
     core::Property CapturePacket::BatchSize("Batch Size", "The number of 
packets to combine within a given PCAP", "50");
    +core::Property CapturePacket::NetworkControllers("Network Controllers", 
"List of network controllers to attach to -- each may be a regex", ".*");
    --- End diff --
    
    the way this is worded is a little awkward.  I understand this could 
resolve to multiple interfaces with the regex but this would make me think I 
could do a csv of regexes although it seems that this would be done by having 
multiple instances of that property.  is the intent to have dynamic properties 
for this?


---

Reply via email to