Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r208027287
  
    --- Diff: extensions/pcap/CapturePacket.cpp ---
    @@ -54,13 +54,15 @@ namespace processors {
     std::shared_ptr<utils::IdGenerator> CapturePacket::id_generator_ = 
utils::IdGenerator::getIdGenerator();
     core::Property CapturePacket::BaseDir("Base Directory", "Scratch directory 
for PCAP files", "/tmp/");
     core::Property CapturePacket::BatchSize("Batch Size", "The number of 
packets to combine within a given PCAP", "50");
    +core::Property CapturePacket::NetworkControllers("Network Controllers", 
"List of network controllers to attach to -- each may be a regex", ".*");
     core::Property CapturePacket::CaptureBluetooth("Capture Bluetooth", "True 
indicates that we support bluetooth interfaces", "false");
     
     const char *CapturePacket::ProcessorName = "CapturePacket";
     
     std::string CapturePacket::generate_new_pcap(const std::string &base_path) 
{
       std::string path = base_path;
       // can use relaxed for a counter
    +  //int cnt = num_.fetch_add(1, std::memory_order_relaxed);
    --- End diff --
    
    err thanks can't believe I missed that. 


---

Reply via email to