[
https://issues.apache.org/jira/browse/MINIFICPP-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636680#comment-16636680
]
ASF GitHub Bot commented on MINIFICPP-627:
------------------------------------------
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/408
MINIFICPP-627 - Remove unnecessary ternary operators, variable shadowing
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-627
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/408.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #408
----
commit 3f1ba66c2889f6cf2532be2ce370daaa7a245964
Author: Arpad Boda <aboda@...>
Date: 2018-10-03T09:31:10Z
MINIFICPP-627 - Remove unnecessary ternary operators, variable shadowing
----
> Remove unnecessary ternary operators, variable shadowing
> --------------------------------------------------------
>
> Key: MINIFICPP-627
> URL: https://issues.apache.org/jira/browse/MINIFICPP-627
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Trivial
>
> There are some "? true : false" operations in the code, which is unnecessary.
> Variable shadowing are to be removed to reduce the possibility of errors when
> touching the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
